-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to support read/write of additional INP/RPT sections #219
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4b7be75
added patterns and controls to Model.inp
kaklise 9c91e65
Replace quotes for inflows
kaklise 64207c5
Find max number of tokens, resolves issue with xsection
kaklise 0049488
changed df index for curves
kaklise 020ca06
check to make sure rule name starts with RULE
kaklise 5241555
Added Pumping Summary to rpt sections and 'Analysis begun on' to read
kaklise f1ce68a
Merge branch 'inp_sections' of https://github.com/kaklise/swmmio into…
kaklise 080a9cb
Added minimal test for INP file read/write/run
kaklise 5df37ba
changed subprocess call to run_simple
kaklise 3398eca
Added pump control model and api docs for controls and patterns
kaklise 2dfd9e4
updated inp sections test to include additional models
kaklise 26a04b6
simplified output
kaklise File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
updated inp sections test to include additional models
- Loading branch information
commit 2dfd9e4b2447bc067ad870d6a47893cd0f4069a4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this test. My only suggestion is that we clean up the artifacts that are created after this test is run. That said, I'm fine with leaving this as is and refactoring our unit tests in a future PR.