Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cleanup code to event_loop that mimics the behavior of asyncio.run #309

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add cleanup code to event_loop that mimics the behavior of asyncio.run #309

wants to merge 7 commits into from

Commits on Sep 13, 2022

  1. Add cleanup code to event_loop that mimics the behavior of asyncio.run

    @Askaholic @seifertm
    Askaholic authored and seifertm committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    8a63a65 View commit details
    Browse the repository at this point in the history

  2. Skip cleanup if the loop was closed in the test

    @Askaholic @seifertm
    Askaholic authored and seifertm committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    effc2e5 View commit details
    Browse the repository at this point in the history

  3. Add test for verifying task cancellation

    @Askaholic @seifertm
    Askaholic authored and seifertm committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    046154d View commit details
    Browse the repository at this point in the history

  4. Move cleanup code to pytest_fixture_post_finalizer

    @Askaholic @seifertm
    Askaholic authored and seifertm committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    a43a7b5 View commit details
    Browse the repository at this point in the history

  5. test: Close event_loop in test_event_loop_scope/test_4 to avoid side-… 

    …effects on other tests.

Signed-off-by: Michael Seifert <[email protected]>
    @seifertm
    seifertm committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    b7f1a16 View commit details
    Browse the repository at this point in the history

  6. fix: Yield loop from event_loop fixture to avoid violating function s… 

    …ignature.

This prevents gc.collect() from being unreachable.

Signed-off-by: Michael Seifert <[email protected]>
    @seifertm
    seifertm committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    03ee1b1 View commit details
    Browse the repository at this point in the history

  7. refactor: Ignore mypy problem when calling asyncio.runners._cancel_al… 

    …l_tasks.

Signed-off-by: Michael Seifert <[email protected]>
    @seifertm
    seifertm committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    5024eb8 View commit details
    Browse the repository at this point in the history