Catch2: fix multiple section failures #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnewb1
force-pushed
the
catch2-fix-section
branch
from
fa73526 to
9ce8ba8
Compare
jnewb1
force-pushed
the
catch2-fix-section
branch
from
d03166c to
73cdc7f
Compare
jnewb1
commented
Sep 8, 2023
Comment on lines
-99
to
-116
| if e.returncode != 1: | ||
| msg = ( | ||
| "Internal Error: calling {executable} " | ||
| "for test {test_id} failed (returncode={returncode}):\n" | ||
| "{output}" | ||
| ) | ||
| failure = Catch2Failure( | ||
| executable, | ||
| 0, | ||
| msg.format( | ||
| executable=executable, | ||
| test_id=test_id, | ||
| output=e.output, | ||
| returncode=e.returncode, | ||
| ), | ||
| ) | ||
|
|
||
| return [failure], output |
There was a problem hiding this comment.
If you get an exit code of >1 (because >1 tests fail), this would force the parser to load the first line of the executable since it's put into the test_file on line 106, which would be in binary and cause an error.
return [x.rstrip() for x in f.readlines()[index_above : index + 1]]
^^^^^^^^^^^^^
File "<frozen codecs>", line 322, in decode
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe0 in position 24: invalid continuation byte
There was a problem hiding this comment.
Ahh definitely, this seems like an oversight.
jnewb1
commented
Sep 8, 2023
| @@ -151,7 +133,7 @@ def _parse_xml( | |||
| test_result = test_case.find("OverallResult") | |||
| failures = [] | |||
| if test_result is not None and test_result.attrib["success"] == "false": | |||
| test_checks = test_case.findall("Expression") | |||
| test_checks = test_case.findall(".//Expression") | |||
There was a problem hiding this comment.
get recursive test checks
for more information, see https://pre-commit.ci
|
Looks great, could you also add a new CHANGELOG entry? Create a new section |
|
Awesome, thanks! After merging this, I will make a new release. Thanks again! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catch2 seems to return an exit code corresponding to the number of tests that fail when using the "SECTION" parameter