Hermes: Add prv publish time metadata #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
ali-bahjati
commented
Sep 21, 2023
| @@ -18,9 +18,8 @@ const argvPromise = yargs(hideBin(process.argv)) | |||
| type: "array", | |||
| demandOption: true, | |||
| }) | |||
| .option("price-service", { | |||
There was a problem hiding this comment.
this is a minor change to move to hermes
ali-bahjati
changed the title
cctdaniel
reviewed
Sep 22, 2023
| @@ -333,7 +334,7 @@ where | |||
| .iter() | |||
| .map(|message_state| match message_state.message { | |||
| Message::PriceFeedMessage(price_feed) => Ok(PriceFeedUpdate { | |||
| price_feed: PriceFeed::new( | |||
| price_feed: PriceFeed::new( | |||
There was a problem hiding this comment.
the extra spacing seems weird but seems like it passes pre-commit 🤔
There was a problem hiding this comment.
yeah it is the rust formatter config that we have :D
cctdaniel
approved these changes
Sep 22, 2023
Reisen
approved these changes
Sep 22, 2023
| pub slot: Option<Slot>, | ||
| pub received_at: Option<UnixTimestamp>, | ||
| pub update_data: Option<Vec<u8>>, | ||
| pub prev_publish_time: Option<UnixTimestamp>, |
There was a problem hiding this comment.
I realise we can't change it at this point but It's a shame this isn't last_publish_time like other last_ fields we have in our codebases.
There was a problem hiding this comment.
i think here prev is more clear than last.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@pythnetwork/price-service-client", | |||
| "version": "1.7.0", | |||
| "version": "1.8.0", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.