Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contract-manager): add script to fetch account balances #1142

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

ali-bahjati
Copy link
Collaborator

No description provided.

@ali-bahjati ali-bahjati requested a review from m30m November 21, 2023 11:30
Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
example-oracle-amm ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 4:53pm
xc-admin-frontend ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 4:53pm

@ali-bahjati ali-bahjati force-pushed the contract-mngr/add-account-balance-script branch from ec4f70c to 3a9f491 Compare November 21, 2023 11:32
Copy link
Collaborator

@m30m m30m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! added a minor comment.

return Number(balance.amount) / 10 ** 6;
}

async getAddress(): Promise<string> {
return (await this.signer.getAccounts())[0].address;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

such a shame that this is async 😢 and made the whole function async in the end.

contract_manager/scripts/fetch_account_balance.ts Outdated Show resolved Hide resolved
@ali-bahjati ali-bahjati force-pushed the contract-mngr/add-account-balance-script branch from 3a9f491 to ae7f31d Compare November 21, 2023 16:53
@ali-bahjati ali-bahjati merged commit 9335898 into main Nov 21, 2023
6 checks passed
@ali-bahjati ali-bahjati deleted the contract-mngr/add-account-balance-script branch November 21, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants