[solana/cosmwasm/near] Rust tests refactor #1238
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
guibescos
changed the title
pythnet/pythnet_sdk/src/gen/mod.rs
Outdated
| }, | ||
| }; | ||
|
|
||
| fn default_emitter_addr() -> [u8; 32] { |
There was a problem hiding this comment.
Some examples of the functions that will live here.
There was a problem hiding this comment.
I like the idea of moving the code somewhere where it can be shared. I'm not sure whether it makes sense in this crate or not though, so I will let @ali-bahjati and @Reisen opine on that.
If they don't like this approach, I think another option would be to make a separate crate like pythnet-sdk-test-utils (?)
|
I definitely think this is a good change. Here are my thoughts: I suggest changing the feature name and module to Then as a structural refactor I think it's better to rename the pythnet-sdk to accumulators-sdk and we can then move it to |
guibescos
force-pushed
the
rust-tests-refactor
branch
from
fa963d7 to
94188ec
Compare
guibescos
force-pushed
the
rust-tests-refactor
branch
from
94188ec to
559cec4
Compare
| price: i64::MAX.into(), | ||
| conf: u64::MAX.into(), | ||
| price: i64::MAX, | ||
| conf: u64::MAX, |
I have the very ambitious project to "move up" a lot of the code that we use to generate accumulator updates in the Rust tests for the rust ecosystems (Cosmwasm, Near and Solana).
This PR is about deciding where this code should live.
I made a feature
geninpythnet-sdkthat exposes the generator functions.The reason why it's feature gated is that I use
wormhole_sdkand I think it's good to be able to usepythnet-sdk without any wormhole dependencies.