-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[solana] Solana tests 2 #1255
[solana] Solana tests 2 #1255
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
.iter() | ||
.map(|x| libsecp256k1::sign(&digest, &x)) | ||
.collect(); | ||
let wormhole_signatures: Vec<wormhole_sdk::vaa::Signature> = signatures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding actual signatures to the common sdk
|
||
let digest = libsecp256k1Message::parse_slice(&body.digest().unwrap().secp256k_hash).unwrap(); | ||
|
||
let signatures: Vec<(Signature, RecoveryId)> = guardians[0..NUM_SIGNATURES] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the number of signatures should be an argument to the function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also do you want it to be the case that it's always the first N guardians who signed? are there possible tests where you want a random subset of guardians or something?
I would think about the range of configurability you need downstream and then try to build that in to the test methods here.
Another similar question would be whether you need the ability to define & work with different guardian sets in the tests. In that case, you may want to make the signing guardian keys an argument to this function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so I switched to having random subsets of guardians. I don't think I need more configurability for now.
The goal of this PR is to expand the testing coverage to
post_updates_atomic
For this we add a way to created signed VAAs to
pythnet_sdk/test-utils
. We also simulate the guardian set account insetup_pyth_receiver
.