Deny clippy warnings in CI properly #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Comment on lines
-43
to
-45
| let sequence: u64 = sequence | ||
| .try_into() | ||
| .map_err(|_| RestError::InvalidSequenceNumber)?; |
There was a problem hiding this comment.
Are you sure the intention here was not to check if try_into() has some errors?
There was a problem hiding this comment.
sequence is already a u64 so try_into() never fails.
ali-bahjati
approved these changes
Nov 11, 2024
| @@ -1,3 +1,5 @@ | |||
| #![allow(clippy::vec_init_then_push)] | |||
There was a problem hiding this comment.
couldn't we move this in? (i mean just fix it perhaps)
There was a problem hiding this comment.
The module contains auto generated code so I feel like it's more convenient to keep this outside so it's easier to update the code if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-commit config in CI previously used
clippy --fix, which makes-D warningshave no effect. Now warnings should be properly denied. I fixed the simple warnings and added allow annonations for more complex cases.