-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required args to subcommand program #1293
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1293 +/- ##
==========================================
- Coverage 98.56% 98.56% -0.01%
==========================================
Files 22 22
Lines 5780 5776 -4
==========================================
- Hits 5697 5693 -4
Misses 83 83 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run black
and add type annotations to address the mypy errors. The changes look reasonable to me. Thanks for finding and addressing this!
Seems like |
@anselor Do you have any guidance for the conflicting flake8 and black rules? |
Sorry, this slipped out of my brain and I didn't notice until now. It looks like the build log is gone and I'm not sure how to rerun the build... |
2bc8b6b
to
19ed6ae
Compare
@anselor I've repushed to kick off the workflow again. |
@rdhammond15 It looks like flake8 recently become opinionated about that. I disagree with E704 being an antipattern. Just go ahead and disable E704 for flake8 globally. |
Issue
When a positional comes before a subcommand, the help output for the subcommand will be missing the positional in the usage. This does not match up with argparse functionality.
Expected Output
Actual Output
Sample Test Program