Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependencies which were only used for Python < 3.8 #1329

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Remove dependencies which were only used for Python < 3.8 #1329

merged 1 commit into from
Oct 7, 2024

Conversation

tleonhardt
Copy link
Member

Remove dependencies which were only used for Python < 3.8 since cmd2 2.5.0 now requires Python 3.8+.

Specifically removed:

  • importlib_metadata
  • typing_extensions

@tleonhardt tleonhardt requested a review from kmvanbrunt October 6, 2024 21:02
@tleonhardt tleonhardt requested a review from kotfu as a code owner October 6, 2024 21:02
@tleonhardt tleonhardt merged commit 16c6d30 into master Oct 7, 2024
40 checks passed
@tleonhardt tleonhardt deleted the remove_uneeded_deps branch October 7, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmvanbrunt kmvanbrunt kmvanbrunt approved these changes

@kotfu kotfu Awaiting requested review from kotfu kotfu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tleonhardt @kmvanbrunt