Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug where async_alert() overwrites readline's incremental and non-incremental search prompts. #1330

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

kmvanbrunt
Copy link
Member

Fixes #1260

@kmvanbrunt kmvanbrunt requested a review from anselor October 11, 2024 02:45
@kmvanbrunt kmvanbrunt force-pushed the fix_search_prompt_overwriting branch 2 times, most recently from f64b86c to 40af297 Compare October 11, 2024 20:24
@kmvanbrunt kmvanbrunt marked this pull request as draft October 12, 2024 02:38
@kmvanbrunt kmvanbrunt force-pushed the fix_search_prompt_overwriting branch 2 times, most recently from 04b0344 to 3782243 Compare October 16, 2024 19:29
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.

Project coverage is 98.34%. Comparing base (ff46021) to head (3782243).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
cmd2/rl_utils.py 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1330      +/-   ##
==========================================
+ Coverage   97.72%   98.34%   +0.62%     
==========================================
  Files          22       22              
  Lines        5753     5806      +53     
==========================================
+ Hits         5622     5710      +88     
+ Misses        131       96      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmvanbrunt kmvanbrunt force-pushed the fix_search_prompt_overwriting branch 2 times, most recently from 8f73072 to a8561f9 Compare October 16, 2024 19:59
@kmvanbrunt kmvanbrunt force-pushed the fix_search_prompt_overwriting branch from a8561f9 to f813b43 Compare October 16, 2024 20:19
@kmvanbrunt kmvanbrunt marked this pull request as ready for review October 16, 2024 20:25
@tleonhardt tleonhardt merged commit 3062aaa into master Oct 16, 2024
40 checks passed
@tleonhardt tleonhardt deleted the fix_search_prompt_overwriting branch October 16, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updating the prompt overwrites incremental search
2 participants