change initialize_problem to require keyword args (#247)

python-hydro · Sep 4, 2024 · 2b2488e · 2b2488e
1 parent 3879ae4
commit 2b2488e
Show file tree

Hide file tree

Showing 6 changed files with 101 additions and 535 deletions.
diff --git a/examples/examples.ipynb b/examples/examples.ipynb
@@ -50,7 +50,7 @@
    "outputs": [],
    "source": [
     "pyro_sim = Pyro(solver)\n",
-    "pyro_sim.initialize_problem(problem_name, param_file)"
+    "pyro_sim.initialize_problem(problem_name, inputs_file=param_file)"
    ]
   },
   {
@@ -198,13 +198,13 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 9,
+   "execution_count": 8,
    "metadata": {},
    "outputs": [],
    "source": [
     "# NBVAL_IGNORE_OUTPUT \n",
     "extra_parameters = {'vis.dovis': False, 'mesh.nx': 8, 'mesh.ny':8, 'particles.do_particles': False}\n",
-    "pyro_sim.initialize_problem(problem_name, param_file, inputs_dict=extra_parameters)\n",
+    "pyro_sim.initialize_problem(problem_name, inputs_file=param_file, inputs_dict=extra_parameters)\n",
     "pyro_sim.run_sim;"
    ]
   },
@@ -217,7 +217,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 10,
+   "execution_count": 9,
    "metadata": {
     "tags": [
      "nbval-ignore-output"
@@ -257,7 +257,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 11,
+   "execution_count": 10,
    "metadata": {},
    "outputs": [],
    "source": [
@@ -266,7 +266,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 12,
+   "execution_count": 11,
    "metadata": {
     "tags": []
    },
@@ -340,7 +340,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 13,
+   "execution_count": 12,
    "metadata": {},
    "outputs": [
     {

diff --git a/presentations/pyro_intro.ipynb b/presentations/pyro_intro.ipynb
diff --git a/pyro/pyro_sim.py b/pyro/pyro_sim.py
@@ -80,7 +80,7 @@ def __init__(self, solver_name, from_commandline=False):
 
         self.is_initialized = False
 
-    def initialize_problem(self, problem_name, inputs_file=None, inputs_dict=None,
+    def initialize_problem(self, problem_name, *, inputs_file=None, inputs_dict=None,
                            other_commands=None):
         """
         Initialize the specific problem