Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline the validate() function #119

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Inline the validate() function #119

wants to merge 3 commits into from

Commits on Nov 18, 2020

  1. Drop support for Python 2

    @bluetech
    bluetech committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    3de0c88 View commit details
    Browse the repository at this point in the history

  2. Get rid of _EventBundle 

    _EventBundle uses a lot of dynamic python features to save on some
duplication, but it slows things down, and will also make it much harder
to add static typing. Since these types are now pretty stable, it seems
not worth it.

On the bench/ micro-benchmark:

Before:  9322.6 requests/sec
After : 10544.6 requests/sec
    @bluetech
    bluetech committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    868d214 View commit details
    Browse the repository at this point in the history

  3. Inline the validate() function 

    It somewhat obscures the control flow and adds some non-trivial
overhead.

Inline it in favor of the direct match/if combination.

On the bench/ microbenchmark:

Before: 10700.2 requests/sec
After : 11334.0 requests/sec
    @bluetech
    bluetech committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    40df2b6 View commit details
    Browse the repository at this point in the history