-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add typing information #1289
base: master
Are you sure you want to change the base?
add typing information #1289
Conversation
`H2Stream` does not have such an attribute - probably added by accident.
@BYK happy to hear your thoughts on the header typing dilemma! |
da55817
to
53fa0ba
Compare
@BYK I think I solved the headers type confusion and now all tests pass again. mypy is almost happy, but I think I would like to hear your input on the few remaining findings as they mostly relate to #1286 :
|
@Kriechi apologies for the very late response, got busy 😅 Regarding your solution for Regarding the errors you pointed out, I'm quite sure they'll go away when you merge #1286 as the whole point of that patch was to remove these inconsistencies and lock everything to |
@BYK the new Though, I just noticed this syntax is not yet supported on Python 3.9... so I need to find a different solution. |
@Kriechi made a suggestion over there. I think that also takes care of the py3.9 issue as it doesn't have nested |
closes #368
This PR goes hand in hand with python-hyper/hpack#277 and python-hyper/hyperframe#163 and might be refined together.
This PR is still a draft. The major outstanding issues are around handling of Headers, with their
(bytes, bytes)
or(str, str)
orHeaderTuple
types. I'm open to suggestions on how to best address these issues. Currently, mypy still reports about 26 typing-related errors and a few tests are failing.