Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove unnecessary string casting of bytes #276

Merged
merged 4 commits into from
Nov 16, 2024
Merged

fix: Remove unnecessary string casting of bytes #276

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b2421a
fix: Remove unnecessary string casting of `bytes`
BYK Nov 14, 2024
10a3fae
even faster
BYK Nov 15, 2024
f90010e
Merge branch 'master' into byk/fix/byte-str-cast
BYK Nov 16, 2024
fb65910
better naming and comment
BYK Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/hpack/hpack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,12 @@ def _to_bytes(string):
"""
Convert string to bytes.
"""
if not isinstance(string, basestring): # pragma: no cover
t = type(string)
if t is bytes:
return string
if t is not str:
string = str(string)

return string if isinstance(string, bytes) else string.encode('utf-8')
return string.encode("utf-8")
BYK marked this conversation as resolved.
Show resolved Hide resolved


class Encoder:
Expand Down
Loading