-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checks to pre-commit #7421
Add checks to pre-commit #7421
Conversation
- id: end-of-file-fixer | ||
exclude: ^Tests/images/ | ||
- id: trailing-whitespace | ||
exclude: ^.github/.*TEMPLATE|^Tests/(fonts|images)/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exclude: ^.github/.*TEMPLATE|^Tests/(fonts|images)/ | |
exclude: ^.github/.*TEMPLATE|^Tests/(fonts|icc|images)/ |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it is fixing the text file in this directory and not touching the binaries. Shall we leave it as is, until it comes up?
For the record, or maybe just as a note to self, this is recommended at https://github.com/psf/black/blob/3dcacdda0d7f69a1705f3e2a151c24a6cf004171/.pre-commit-hooks.yaml#L1-L2
|
Also in the docs here: https://black.readthedocs.io/en/stable/integrations/source_version_control.html |
check-executables-have-shebangs
and remove executable flagsend-of-file-fixer
, excludingTests/images/
trailing-whitespace
, excluding some templates, test fonts and images