Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks to pre-commit #7421

Merged
merged 8 commits into from
Sep 28, 2023
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 25, 2023

@hugovk hugovk added the Testing label Sep 25, 2023
- id: end-of-file-fixer
exclude: ^Tests/images/
- id: trailing-whitespace
exclude: ^.github/.*TEMPLATE|^Tests/(fonts|images)/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
exclude: ^.github/.*TEMPLATE|^Tests/(fonts|images)/
exclude: ^.github/.*TEMPLATE|^Tests/(fonts|icc|images)/

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it is fixing the text file in this directory and not touching the binaries. Shall we leave it as is, until it comes up?

@radarhere radarhere assigned radarhere and unassigned radarhere Sep 27, 2023
@radarhere
Copy link
Member

  • Update Black and switch to the mirror repo for faster mypyc wheels

For the record, or maybe just as a note to self, this is recommended at https://github.com/psf/black/blob/3dcacdda0d7f69a1705f3e2a151c24a6cf004171/.pre-commit-hooks.yaml#L1-L2

# Note that we recommend using https://github.com/psf/black-pre-commit-mirror instead
# This will work about 2x as fast as using the hooks in this repository

@radarhere radarhere merged commit 26fc975 into python-pillow:main Sep 28, 2023
52 of 53 checks passed
@hugovk hugovk deleted the update-pre-commit branch September 28, 2023 10:09
@hugovk
Copy link
Member Author

hugovk commented Sep 28, 2023

@hugovk hugovk mentioned this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants