Added reading 8-bit color DDS images #7426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7423
The issue has found a DDS image that has the
DDPF_PALETTEINDEXED8
pixel formatPillow/src/PIL/DdsImagePlugin.py
Lines 46 to 50 in b723e9e
This pixel format is not mentioned at https://learn.microsoft.com/en-us/windows/win32/direct3ddds/dds-pixelformat under "dwFlags", but is at https://learn.microsoft.com/en-us/previous-versions/ms783269(v=vs.85). It is an "8-bit color indexed" image.
Looking at the data in the issue, I guessed that the file structure was the header, followed by 1024 palette bytes, followed by the indexes to the palette. That produced a good result.
To create a test image, I took the header from hopper.dds, manually changed the width, height and pixel format flags, and put together code to write out the palette and indexes of transparent.gif.