Fixed closing file pointer with olefile 0.47 #7594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 2, 2023
|
Thanks, let's merge this to get the CI green. It was the first olefile release in five years. Do you think this might be an olefile bug? |
|
It's not a bug, no, it's decalage2/olefile#121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
olefile 0.47 was released in the last day. It has made a change since 0.46, that if it did not open a file pointer, it will no longer close it with
close(). This is mentioned on PyPI as 'improved file closure'.This has broken our file closing tests in the Test and Test Windows workflows for FPX and MIC.
To fix them,
self._fp, which is then closed byImage.close()orImage.__exit__()._fp, so I have slightly less simply kept the original file pointer asself.__fpand closed it within MicImagePlugin.I checked that this still works with olefile 0.46 by downgrading it and observing that it passes on the Test and Test WIndows workflows.