Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filename placeholder in winbuild URL #8498

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Oct 25, 2024

There are several places in winbuild/build_prepare.py where the "filename" is replicated in the "url"

"zlib": {
"url": f"https://zlib.net/zlib{V['ZLIB_DOTLESS']}.zip",
"filename": f"zlib{V['ZLIB_DOTLESS']}.zip",

I wonder if

"zlib": {
    "url": "https://zlib.net/FILENAME",
    "filename": f"zlib{V['ZLIB_DOTLESS']}.zip",

is neater, reducing duplication?

Feel free to reject if others think it isn't simpler.

@@ -131,7 +131,7 @@ def cmd_msbuild(
DEPS: dict[str, dict[str, Any]] = {
"libjpeg": {
"url": f"{SF_PROJECTS}/libjpeg-turbo/files/{V['JPEGTURBO']}/"
f"libjpeg-turbo-{V['JPEGTURBO']}.tar.gz/download",
"FILENAME/download",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string probably fits on a single line now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I've pushed a commit.

@radarhere radarhere merged commit 64eed14 into python-pillow:main Oct 26, 2024
65 of 66 checks passed
@radarhere radarhere deleted the winbuild branch October 26, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants