-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wheel.py #260
Update wheel.py #260
Conversation
Fix an error that caused excluded files to be added to the wheel
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please provide a test that covers this change?
I currently don't have the time to write a complete test case that could be integrated here, but I have produced a minimal example to showcase this issue: Building this results in:
Note the adding after the In this example I had to remove the other bug that is fixed in with #228 because I could not get a poetry version that includes the fix even an: |
Closing as this cannot be reproduced anymore. It is likely that this was fixed elsewhere. Thank you for your contribution. podman run --rm -i --entrypoint bash docker.io/python:3.10 <<EOF
set -xe
python -m pip install --disable-pip-version-check --root-user-action ignore -q poetry
git clone https://github.com/nylocx/poetry-cython-demo.git
cd poetry-cython-demo
poetry build -f wheel
unzip -v dist/*.whl
EOF + unzip -v dist/poetry_cython_demo-0.1.0-cp310-cp310-manylinux_2_36_x86_64.whl
Archive: dist/poetry_cython_demo-0.1.0-cp310-cp310-manylinux_2_36_x86_64.whl
Length Method Size Cmpr Date Time CRC-32 Name
-------- ------ ------- ---- ---------- ----- -------- ----
22 Defl:N 24 -9% 2016-01-01 00:00 e9710a82 poetry_cython_demo/__init__.py
105885 Defl:N 18588 82% 2016-01-01 00:00 9d5d98b1 poetry_cython_demo/cython_code.c
250 Defl:N 134 46% 2016-01-01 00:00 033e4fd9 poetry_cython_demo-0.1.0.dist-info/METADATA
110 Defl:N 106 4% 2016-01-01 00:00 6da57f03 poetry_cython_demo-0.1.0.dist-info/WHEEL
415 Defl:N 263 37% 2016-01-01 00:00 87dc3624 poetry_cython_demo-0.1.0.dist-info/RECORD
-------- ------- --- -------
106682 19115 82% 5 files |
Was resolved by #228. |
Fix an error that caused excluded files to be added to the wheel
Resolves: python-poetry#