Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant code #64

Merged
merged 1 commit into from
May 26, 2022
Merged

remove redundant code #64

merged 1 commit into from
May 26, 2022

Conversation

dimbleby
Copy link
Contributor

Not clear to me what this code was trying to do but it doesn't seem to be anything useful.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@radoering
Copy link
Member

I have in mind that this was still required at some point when we moved the code from poetry to the export plugin and a test failed without it. Since no tests are failing it may not be required anymore.

Maybe, @abn has a better memory.

@dimbleby
Copy link
Contributor Author

The code in the locker did get a big rework at python-poetry/poetry#5156, I wouldn't be at all surprised to learn that this made some workaround unnecessary

@abn
Copy link
Member

abn commented May 25, 2022

A lot of things changed in core too since the groups work started. I recall from the initial rework for locker done in poetry 1.1.0 release a, lot of things were fudged.

From what I can tell it is no longer required and I am good with that.

@neersighted neersighted merged commit 0ff74f3 into python-poetry:main May 26, 2022
@dimbleby dimbleby deleted the simplify branch May 26, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants