Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from deprecated trio.Queue; fix tests; fix docs #49

Merged
merged 3 commits into from
Dec 9, 2018

Conversation

Zac-HD
Copy link
Member

@Zac-HD Zac-HD commented Dec 9, 2018

Closes #46.

Releasing a new version of trio-asyncio with this change will unblock python-trio/pytest-trio#68 - cc @njsmith

@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@288abcb). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #49   +/-   ##
=========================================
  Coverage          ?   73.33%           
=========================================
  Files             ?       11           
  Lines             ?     1264           
  Branches          ?      165           
=========================================
  Hits              ?      927           
  Misses            ?      282           
  Partials          ?       55
Impacted Files Coverage Δ
trio_asyncio/base.py 85.39% <100%> (ø)
trio_asyncio/async_.py 85% <100%> (ø)
trio_asyncio/sync.py 81.1% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 288abcb...f56c4be. Read the comment docs.

@Zac-HD Zac-HD changed the title Upgrade from deprecated trio.Queue Upgrade from deprecated trio.Queue; fix tests; fix docs Dec 9, 2018
@Zac-HD Zac-HD merged commit 81b7c81 into python-trio:master Dec 9, 2018
@Zac-HD Zac-HD deleted the remove-queue branch December 9, 2018 03:37
@Zac-HD
Copy link
Member Author

Zac-HD commented Dec 9, 2018

Ping @smurfix - can you make a release soon to unblock pytest-trio? Thanks!

@pquentin
Copy link
Member

pquentin commented Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants