Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removals as a newsfragment type #2850

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Nov 2, 2023

Fixes #2846

cc @CoolCat467 about changing the category for your newsfragment.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2850 (f468504) into master (3b6b167) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2850   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         115      115           
  Lines       17596    17596           
  Branches     3143     3143           
=======================================
  Hits        17453    17453           
  Misses         99       99           
  Partials       44       44           

@CoolCat467
Copy link
Member

I know it says there should be two reviews, but I think this should be simple enough and doesn't even change code, so I am going to merge this.

@CoolCat467 CoolCat467 merged commit c979257 into python-trio:master Nov 2, 2023
27 checks passed
@A5rocks A5rocks deleted the add-removals branch November 2, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

removal newsfragments do not show in history
2 participants