-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ruff's flake8-commas
rule
#3044
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3044 +/- ##
==========================================
- Coverage 99.61% 99.60% -0.02%
==========================================
Files 121 121
Lines 17880 17884 +4
Branches 3214 3215 +1
==========================================
+ Hits 17812 17813 +1
- Misses 48 50 +2
- Partials 20 21 +1
|
|
pre-commit.ci autofix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spot-checks fine. I'm not sure how useful this will be, though forcing noqa
and type: ignores
onto lines with only that argument is actually useful.
Though, can you put this in a blame-ignore file?
it's also generally useful for minimizing diffs when only changing a single argument. And yes, this should be in blame-ignore. If you wanna be strictly correct you can reshuffle the commits so there's one that is pure refactoring, and one that contains the functional changes to
after some brief testing it appears it's possible to add the hash to If you mess up, there's |
351f6ca
to
810534d
Compare
In this pull request, we enable ruff's
flake8-commas
rule and handle all the reformatting black does because of this.No functional changesHad to updategen_exports
to run black a 2nd time, if/when this is merged it will probably need to be added to the purely formatting commits thing jakkdl was talking about a while ago.