Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reason for failed match to RaisesGroup #3145
base: main
Are you sure you want to change the base?
Add reason for failed match to RaisesGroup #3145
Changes from 22 commits
03a3959
c0dcb58
2b98b2f
f84d9d1
df27595
993a173
656e040
debe557
a8e263c
8281d7c
3f757f1
a62a252
5efafd5
6ab9ac9
f38d63b
b6ce586
ebbf694
9748cc8
89bf77e
ba938bc
9612d1e
580137d
baa7a2f
c6dffa8
3360b30
6f7efe5
d6a0145
38d95c5
8129c1d
2a7c9ab
29ceb0d
fc7a0ab
b606fb4
1091b81
0cc3968
561660b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could try tossing attrs on them and seeing! But I think so too.
Maybe even just try putting
__slots__
on them and using that to double check, then removing this (checked) comment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh, they're passing locally (but a bunch of other classes aren't 🙃)
and this is running through a minimal tox with
-r test-requirements.txt
as the only dep so I have no clue what's going on. That's for another day