Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fail_at() doc fix #516

Merged
merged 1 commit into from
May 5, 2018
Merged

Conversation

sorcio
Copy link
Contributor

@sorcio sorcio commented May 4, 2018

No description provided.

@sorcio
Copy link
Contributor Author

sorcio commented May 4, 2018

Ignore the CI failure, it's #508 again.

Collecting sortedcontainers (from trio==0.4.0+dev)
  1 location(s) to search for versions of sortedcontainers:
  * https://pypi.org/simple/sortedcontainers/
  Getting page https://pypi.org/simple/sortedcontainers/
  Looking up "https://pypi.org/simple/sortedcontainers/" in the cache
  Current age based on date: 237310
  Freshness lifetime from max-age: 600
  Freshness lifetime from request max-age: 600
  https://pypi.org:443 "GET /simple/sortedcontainers/ HTTP/1.1" 304 0
  Skipping page https://pypi.org/simple/sortedcontainers/ because of Content-Type: unknown
  Could not find a version that satisfies the requirement sortedcontainers (from trio==0.4.0+dev) (from versions: )

@njsmith
Copy link
Member

njsmith commented May 4, 2018

Nice catch! We have branch protection enabled, so we can't easily merge without the CI passing, so I'm going to try to joggle jenkins into re-running...

@njsmith njsmith closed this May 4, 2018
@njsmith njsmith reopened this May 4, 2018
@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #516 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
- Coverage   99.27%   99.26%   -0.01%     
==========================================
  Files          89       89              
  Lines       10405    10405              
  Branches      721      721              
==========================================
- Hits        10330    10329       -1     
  Misses         58       58              
- Partials       17       18       +1
Impacted Files Coverage Δ
trio/_timeouts.py 100% <ø> (ø) ⬆️
trio/tests/test_highlevel_open_tcp_listeners.py 99.29% <0%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f15b7f...e7f07a2. Read the comment docs.

@Fuyukai
Copy link
Member

Fuyukai commented May 4, 2018

That didn't work either. Try 2.

@Fuyukai Fuyukai closed this May 4, 2018
@Fuyukai Fuyukai reopened this May 4, 2018
@njsmith
Copy link
Member

njsmith commented May 5, 2018

We gotta fix that coverage flapping in test_highlevel_open_tcp_listeners.py too... I'm tempted to just # pragma: no cover the whole function because it's a little helper that we don't care about, but it bothers me that I don't understand how that coverage result is possible.

Anyway, this change is fine of course, thank you :-). Is this really your first PR? I'll send the invitation in a moment...

@njsmith njsmith merged commit 39b479e into python-trio:master May 5, 2018
@njsmith
Copy link
Member

njsmith commented May 5, 2018

Is this really your first PR?

Oh right, of course this is because I've been delinquent in reviewing #473. Let me do that right now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants