Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always fill out PR title after conflict resolution #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Feb 5, 2021

  1. Always fill out PR title after conflict resolution

    Before this change, cherry-picker used to loose the backported commit
    message and didn't pass anything to the `push_to_remote()` method which
    resulted in sending an API request to GitHub that had an empty title
    upon resume. This caused GitHub respond with an error.
    
    This code path was only problematic for people having a GitHub token in
    their env and therefore enjoying the benefits of the PR autocreation.
    
    After this change, cherry-picker picks up the commit message correctly
    and extracts the proper PR title and body out of it.
    webknjaz committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    a86a1a2 View commit details
    Browse the repository at this point in the history