Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-126133: Only use start year in PSF copyright, remove end years #126236

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 31, 2024

Lib/email/_parseaddr.py Show resolved Hide resolved
Lib/email/feedparser.py Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case (where there's multiple consecutive entries) makes me slightly prefer the -present form, as we have [1991-1995], [1995-2000], [2001], and then 2001 again. Or, we could remove the end years from the old entries, but I assume that would be more difficult to do?

A

@@ -1,4 +1,4 @@
# Copyright (C) 2001-2007 Python Software Foundation
# Copyright (C) 2001 Python Software Foundation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove the copyright comments in files where the sole holder is the PSF? The general licence would cover this, I think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my personal preference is to not remove statements that exist. just get us out of the continually sometimes updating the year heck. :)

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk hugovk marked this pull request as ready for review November 12, 2024 13:58
@hugovk hugovk requested review from a team and rhettinger as code owners November 12, 2024 13:58
@hugovk hugovk merged commit 91f4908 into python:main Nov 12, 2024
50 of 52 checks passed
@hugovk hugovk deleted the copyright-psf-single-year branch November 12, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants