GH-117759: Update GC docs for incremental collection #126695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
markshannon
commented
Nov 11, 2024
•
markshannon
commented
- Issue: Document the new incremental GC #117759
markshannon
changed the title
3 tasks
Co-authored-by: Daniel Hollas <[email protected]>
iritkatriel
reviewed
Nov 12, 2024
iritkatriel
reviewed
Nov 13, 2024
InternalDocs/garbage_collector.md
Outdated
| generations. The main idea behind this concept is the assumption that most | ||
| objects have a very short lifespan and can thus be collected soon after their | ||
| creation. This has proven to be very close to the reality of many Python | ||
| In order to limit the time each garbage collection takes, the GC implementation |
There was a problem hiding this comment.
Suggested change
| In order to limit the time each garbage collection takes, the GC implementation | |
| In order to bound the length of each garbage collection pause, the GC implementation |
iritkatriel
reviewed
Nov 13, 2024
InternalDocs/garbage_collector.md
Outdated
Comment on lines
369
to
370
| The time taken to scan the young generation can be controlled by controlling the | ||
| size of the young, but the size of the old generation cannot be controlled. |
There was a problem hiding this comment.
Suggested change
| The time taken to scan the young generation can be controlled by controlling the | |
| size of the young, but the size of the old generation cannot be controlled. | |
| The time taken to scan the young generation can be controlled by controlling its | |
| size, but the size of the old generation cannot be controlled. |
InternalDocs/garbage_collector.md
Outdated
| Each full scavenge is performed in a series of increments. | ||
| For each full scavenge, the combined increments will cover the whole heap. | ||
|
|
||
| For each increment, the portion of the heap scanned by a single collection is |
There was a problem hiding this comment.
what does "by a single collection" mean here?
iritkatriel
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.