gh-126991: Fix reference leak in _pickle.c's load_build #126990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If PyObject_SetItem() fails in the `load_build()` function of _pickle.c, no DECREF for the `dict` variable
ZeroIntensity
changed the title
ZeroIntensity
added
needs backport to 3.12
serhiy-storchaka
approved these changes
Nov 19, 2024
|
Thanks @Legoclones for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 19, 2024
…ythonGH-126990) If PyObject_SetItem() fails in the `load_build()` function of _pickle.c, no DECREF for the `dict` variable. (cherry picked from commit 29cbcbd) Co-authored-by: Justin Applegate <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 19, 2024
…ythonGH-126990) If PyObject_SetItem() fails in the `load_build()` function of _pickle.c, no DECREF for the `dict` variable. (cherry picked from commit 29cbcbd) Co-authored-by: Justin Applegate <[email protected]>
|
GH-127018 is a backport of this pull request to the 3.13 branch. |
|
GH-127019 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Nov 19, 2024
…GH-126990) (GH-127019) If PyObject_SetItem() fails in the `load_build()` function of _pickle.c, no DECREF for the `dict` variable. (cherry picked from commit 29cbcbd) Co-authored-by: Justin Applegate <[email protected]>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Nov 19, 2024
…GH-126990) (GH-127018) If PyObject_SetItem() fails in the `load_build()` function of _pickle.c, no DECREF for the `dict` variable. (cherry picked from commit 29cbcbd) Co-authored-by: Justin Applegate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference leak in load_build of _pickle.c
If PyObject_SetItem() fails in the
load_build()function of _pickle.c, no DECREF for thedictvariableIssue - #126991