-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add social cards generation support in sphinxext-opengraph #129085
doc: add social cards generation support in sphinxext-opengraph #129085
Conversation
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
I don't quite the See also python/docsbuild-scripts#147 where I considered this two years ago, where I had concerns about it generating (at the time) 482 images and 41 MB, multiplied by all the languages and versions. cc @AA-Turner |
And also |
Thanks for the tag Hugo, I missed this PR as it didn't have the I'm likewise unsure about what this is meant to achieve, if we want to generate the opengraph preview images then we should enable it via A |
See also #101639, #101642, and #125264 where we tried A |
…ph (python#129085)" This reverts commit 382340d.
I've opened #129106 as a proposal for a clean revert, and I've been working with Hugo to try and set up preview images through A |
No, the opposite. We don't want to try to install We don't use the Python build from source to deploy the website, so the missing optional dependency doesn't really matter there. This patch makes the dependency available on our docs deployment job, which is what we really care about. |
Ah, gotcha, I guess I was under the incorrect impression. |
Ah sorry, the logic is indeed the right way around. I'd tested it locally and wondered why images weren't created, and it's because they're not generated when Anyway, thanks for picking this up, python/docsbuild-scripts#147 had been sitting idle for too long! We've made python/docsbuild-scripts#242 and #129120 to trial it on 3.14, and we can check the performance and space used is okay. |
https://github.com/wpilibsuite/sphinxext-opengraph/blob/d557f8d27fda106a4ebcb6921ce9b278b724938c/sphinxext/opengraph/__init__.py#L12-L19
📚 Documentation preview 📚: https://cpython-previews--129085.org.readthedocs.build/