bpo-38839: Fix some unused functions in tests #17189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst developing PyCQA/pyflakes#485 I ran it against the CPython code base and found these examples of unused functions that I think need fixing.
adamchainz
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
|
@adamchainz thanks for the PR! I have reviewed all but the test_asynchat changes and will finish that bit hopefully by the end of the week. And if you would be willing to open an issue and add a NEWS entry thanking yourself that would be great! |
adamchainz
changed the title
|
I think I've done them both now @brettcannon ! |
brettcannon
reviewed
Nov 18, 2019
Misc/NEWS.d/next/Tests/2019-11-18-22-10-55.bpo-38839.di6tXv.rst
Outdated
Show resolved
Hide resolved
Co-Authored-By: Brett Cannon <[email protected]>
brettcannon
approved these changes
Nov 19, 2019
|
Thanks, @adamchainz ! |
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst developing PyCQA/pyflakes#485 I ran it against the CPython code base and found these examples of unused functions that I think need fixing.
https://bugs.python.org/issue38839