Add section on keeping CI green #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hugovk
reviewed
Nov 3, 2023
Comment on lines
527
to
531
| If this still doesn't help with the failure on the PR, you can try | ||
| to re-run that particular failed check. Go to the red GitHub Action job, | ||
| and find a button on the top right called "Re-run jobs". Select | ||
| "Re-run failed jobs". The button will only be present when all other jobs | ||
| finished running. |
There was a problem hiding this comment.
Only applies to core devs and triagers?
There was a problem hiding this comment.
That's also true for the previous paragraph (about merging in main).
There was a problem hiding this comment.
Any contributor can merge main into their PR, for example: python/cpython#105984 (commits)
Comment on lines
527
to
531
| If this still doesn't help with the failure on the PR, you can try | ||
| to re-run that particular failed check. Go to the red GitHub Action job, | ||
| and find a button on the top right called "Re-run jobs". Select | ||
| "Re-run failed jobs". The button will only be present when all other jobs | ||
| finished running. |
There was a problem hiding this comment.
That's also true for the previous paragraph (about merging in main).
ezio-melotti
reviewed
Nov 3, 2023
Comment on lines
+511
to
+512
| PR. If you happen to have any insight into the failure, let the author know | ||
| in a review comment. CI runs sometimes generate thousands of lines of output. |
There was a problem hiding this comment.
They might also be able to fix them themselves.
Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Ezio Melotti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-devguide--1215.org.readthedocs.build/