-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline tabs on Documentation Getting Started page for commands on different systems #1224
Add inline tabs on Documentation Getting Started page for commands on different systems #1224
Conversation
On this page, we originally had:
So we can lump all those under Unix, and just have two tabs: Unix and macOS. The JavaScript tab selector (please add it like #1223 (comment)) will default to Unix, so it that's fine for macOS.
Yeah, let's see how it goes with tabs here. So for the Unix tab, just the Unix bit of this: And for the Windows tab, the Windows bit of this, plus "Important" note: We also have a few Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ISTM that all the commands on this page that are valid for Unix are also valid for macOS, so we should be able to merge those two tabs. Using Unix/macOs
as tab name throughout the page should be fine as well, but I haven't tested it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
This PR should close a single TODO in #1196.
There is a little bit of discussion in the Build using make / make.bat section. My understanding is the commands are the same so I didn't try to make tabs for them all, but we can adjust if you believe that's better.
📚 Documentation preview 📚: https://cpython-devguide--1224.org.readthedocs.build/documentation/start-documenting/