-
-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline tabs on Increase Test Coverage page for commands on different systems #1228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of the page has ./python X
and make X
commands that we tabify to help macOS/Windows users copy and paste the right one.
And let's also add the JS.
Thank you for the explicit repetition on this instruction.
I just want to clarify something before adding all of the tabs. There's a line earlier in the doc after installing Should we change all of these commands to It feels like a cleaner change, but having not gone through this document myself, I'm unaware if it will add confusion. Another possibility would be to prepend a |
Yeah, I saw that "You can now..." line earlier and wasn't sure... I haven't actually used any of the instructions on this page, they might be outdated and need updating at some point, so let's not worry too much about them now and update them later, if needed. So I suggest we leave those |
Sounds good 👍 I ended up forking cpython so that I could test building the docs on my Windows machine because it felt like the command might be the same on all OSes. Verdict: the |
Hmm, now we have three "Unix" / "macOS" / "Windows" tabs at the top. And further down two "Unix/macOS" / "Windows" tabs. The auto-detection is fine on first load, and if for example you start with macOS, then select "Windows", they all flip over. Good so far. But if you then select "macOS", it doesn't also flip to the "Unix/macOS" one. But I don't think it really matters, it's just another click. Thanks! |
This PR should close a single TODO in #1196.
📚 Documentation preview 📚: https://cpython-devguide--1228.org.readthedocs.build/testing/coverage/