Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify when to use versionadded and versionchanged #1264

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 26, 2024

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@erlend-aasland
Copy link
Contributor Author

Thanks for the review; I'll wait for CAM to chime in before landing!

Co-authored-by: Jelle Zijlstra <[email protected]>
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few suggestions, one of which requires adding a new ref target label, .. _information-units, above the eponymous section.

documentation/markup.rst Outdated Show resolved Hide resolved
documentation/markup.rst Outdated Show resolved Hide resolved
erlend-aasland and others added 2 commits January 26, 2024 20:14
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
@erlend-aasland
Copy link
Contributor Author

Thanks! A few suggestions, one of which requires adding a new ref target label, .. _information-units, above the eponymous section.

Thanks! I'm on mobile until tomorrow, so feel free to take care of it and land the PR :)

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @erlend-aasland !

@CAM-Gerlach CAM-Gerlach merged commit a92330c into python:main Jan 26, 2024
4 checks passed
@erlend-aasland erlend-aasland deleted the versionchanged-versionadded branch January 26, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants