Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advice on copyright notices and PRs #1470

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 12, 2024

Closes python/cpython#126133.

Re: python/cpython#126133 (comment), this is so we can link to this section if we get PRs attempting to update copyright years each year.

Feedback welcome on wording and where to put this in the devguide.


📚 Documentation preview 📚: https://cpython-devguide--1470.org.readthedocs.build/

@malemburg
Copy link
Member

malemburg commented Nov 12, 2024

You should also add a note that for most code in the PSF CPython distribution, the PSF does not own the copyright, but only has redistribution rights to that code, so randomly applying the PSF copyright notice is often plain wrong.

There were a few copyright assignments in the past, but I'm not sure whether we really have a complete list of those. Only code which falls under one of these assignments is legally copyrighted by the PSF.

Note that the PSF does own the copyright on the CPython distributions, i.e. the compilation of the files which make up CPython, which is why there is a copyright statement in the README and the LICENSE.

@hugovk
Copy link
Member Author

hugovk commented Nov 12, 2024

Thanks for the info.

I'd prefer to keep this particular change scoped only about the existing notices, not about adding any new notices, or how copyright applies. It's primarily so we have something to point at if we get PRs adding new years to the list.

Please could you open a new issue or PR if you'd like to extend it? Thank you!

@@ -16,7 +14,7 @@

# General information about the project.
project = "Python Developer's Guide"
copyright = f'2011-{time.strftime("%Y")}, Python Software Foundation'
copyright = '2011 Python Software Foundation'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarifying that this date applies to the devguide only.

@hugovk hugovk merged commit 33ce74b into python:main Nov 21, 2024
5 checks passed
@hugovk hugovk deleted the copyright-guidance branch November 21, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use static copyright years
3 participants