Replace og:image with 200x200 logo #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #953.
We found in python/cpython#99931 (comment) that using just the Python logo is a better use of space than the logo and large "Devguide" text - the old way is better for a flashy splash banner; the new way fills in more of the relevant article text.
Uses the same logo image file as python/cpython#99931.
I also renamed the PNG file to ensure Facebook doesn't serve a cached version. Reportedly Facebook is meant to clear their caches after 24 hours but also reportedly they may not do that for weeks.
Before and after
Facebook
Slack
Discord