Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forgotten reveal_type import in documentation #16619

Closed
wants to merge 1 commit into from

Conversation

Sukonnik-Illia
Copy link

In my opinion documentation reader should see all library imports in code examples even if they are not supposed to be runnable.

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but as a convenience feature for dev, mypy will actually understand reveal_type even if it's not imported

In fact, the runtime symbol only exists in typing module in 3.11 onwards so this PR might actually confuse / not work for users on older Pythons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants