Fix misleading error message: Mypy shoould not suggest Foo[...] if annotation contains Foo(arg=...) etc. #16643
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne in the function visitCall in mypy/fastparse.py
|
Diff from mypy_primer, showing the effect of this PR on open source code: prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/client/schemas/objects.py:1188: note: Suggestion: use conint[...] instead of conint(...)
+ src/prefect/client/schemas/objects.py:1188: note: No Suggestion
- src/prefect/server/schemas/core.py:941: note: Suggestion: use conint[...] instead of conint(...)
+ src/prefect/server/schemas/core.py:941: note: No Suggestion
ibis (https://github.com/ibis-project/ibis)
- ibis/expr/tests/test_schema.py:315: note: Suggestion: use dt.Array[...] instead of dt.Array(...)
+ ibis/expr/tests/test_schema.py:315: note: No Suggestion
- ibis/expr/datatypes/tests/test_core.py:113: note: Suggestion: use dt.Timestamp[...] instead of dt.Timestamp(...)
+ ibis/expr/datatypes/tests/test_core.py:113: note: No Suggestion
- ibis/expr/datatypes/tests/test_core.py:114: note: Suggestion: use dt.Timestamp[...] instead of dt.Timestamp(...)
+ ibis/expr/datatypes/tests/test_core.py:114: note: No Suggestion
- ibis/expr/datatypes/tests/test_core.py:115: note: Suggestion: use dt.Interval[...] instead of dt.Interval(...)
+ ibis/expr/datatypes/tests/test_core.py:115: note: No Suggestion
- ibis/expr/datatypes/tests/test_core.py:117: note: Suggestion: use dt.Decimal[...] instead of dt.Decimal(...)
+ ibis/expr/datatypes/tests/test_core.py:117: note: No Suggestion
- ibis/expr/datatypes/tests/test_core.py:118: note: Suggestion: use dt.Array[...] instead of dt.Array(...)
+ ibis/expr/datatypes/tests/test_core.py:118: note: No Suggestion
- ibis/expr/datatypes/tests/test_core.py:119: note: Suggestion: use dt.Map[...] instead of dt.Map(...)
+ ibis/expr/datatypes/tests/test_core.py:119: note: No Suggestion
- ibis/backends/datafusion/udfs.py:21: note: Suggestion: use dt.Timestamp[...] instead of dt.Timestamp(...)
+ ibis/backends/datafusion/udfs.py:21: note: No Suggestion
- ibis/backends/datafusion/udfs.py:29: note: Suggestion: use dt.Timestamp[...] instead of dt.Timestamp(...)
+ ibis/backends/datafusion/udfs.py:29: note: No Suggestion
- ibis/backends/datafusion/udfs.py:41: note: Suggestion: use dt.Timestamp[...] instead of dt.Timestamp(...)
+ ibis/backends/datafusion/udfs.py:41: note: No Suggestion
- ibis/backends/datafusion/udfs.py:49: note: Suggestion: use dt.Timestamp[...] instead of dt.Timestamp(...)
+ ibis/backends/datafusion/udfs.py:49: note: No Suggestion
- ibis/backends/datafusion/udfs.py:110: note: Suggestion: use dt.Timestamp[...] instead of dt.Timestamp(...)
+ ibis/backends/datafusion/udfs.py:110: note: No Suggestion
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16506
Changed the suggestion made by mypy for the following error
error: Invalid type comment or annotation [valid-type]In the case that the type of the
self.parent()is None, instead of suggestingnote: Suggestion: use Foo[...] instead of Foo(...)mypy will not suggest anything at all.We also added a test case in mypy similar to that mentioned in issues to verify that the mypy prompts the correct error.