Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Github actions ARM runners for tests #18483

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

@cdce8p cdce8p marked this pull request as draft January 17, 2025 13:35

This comment has been minimized.

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, looks like it's 1.5x faster cc @JukkaL who will appreciate this :-)

@cdce8p
Copy link
Collaborator Author

cdce8p commented Jan 18, 2025

Sweet, looks like it's 1.5x faster cc @JukkaL who will appreciate this :-)

Not sure it's ready for us here quite yet. Last I checked there was an issue with the environment variables, which should be fixed soon. This PR works only due to a temporary fix. I'd also like to wait for a new release of actionlint so we don't have to pin the current sha, unless that takes much longer.

Let's see how it looks next week.

Note: The env var issue doesn't effect cibuildwheels which is why we're able to start using the new runner there already.

@cdce8p cdce8p force-pushed the github-actions-arm branch 2 times, most recently from b6b734d to 7fb251b Compare January 18, 2025 11:04

This comment has been minimized.

@cdce8p cdce8p force-pushed the github-actions-arm branch from 7fb251b to 2bd50ec Compare January 19, 2025 12:06
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@cdce8p cdce8p marked this pull request as ready for review January 19, 2025 12:32
@cdce8p
Copy link
Collaborator Author

cdce8p commented Jan 19, 2025

Let's see how it looks next week.

Seems we didn't even need that week. It's ready now. The environment variable issue was resolved Friday and actionlint released a new version with the updated runs-on tags today.

There might still be the occasional issue, e.g. I've read that actions/checkout isn't completely fine, but a restart of the job should generally fix it. It will also only improve with time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants