Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 740: Mark as Final #4114

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

woodruffw
Copy link
Contributor

@woodruffw woodruffw commented Nov 7, 2024

This is my first time marking a PEP as final, apologies if I've missed a step! I've gone Provisional -> Final based on that being a documented valid transition in PEP 1.

Supporting points:

  • PEP 740 roadmap on PyPI is complete: [Roadmap] Implement PEP 740 pypi/warehouse#15871
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive (or canonical-pypa-spec, for packaging PEPs)

CC @di @dstufft 🙂


📚 Documentation preview 📚: https://pep-previews--4114.org.readthedocs.build/

Signed-off-by: William Woodruff <[email protected]>
@AA-Turner AA-Turner changed the title PEP 740: Mark as final PEP 740: Mark as Final Nov 7, 2024
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could add a canonical link to the PEP 740 documentation in PyPI?

A

@JelleZijlstra
Copy link
Member

Could also add a date (17-Jul-2024) to the Resolution header while you're here.

@woodruffw
Copy link
Contributor Author

Done and done! The PyPI docs aren't a copy of the standard per se (they're user facing), so I'm not 100% certain they're right in that position. But FWICT other PEPs use canonical-doc in a similar manner.

peps/pep-0740.rst Outdated Show resolved Hide resolved
Co-authored-by: Adam Turner <[email protected]>
@encukou
Copy link
Member

encukou commented Nov 8, 2024

Would it be possible to add the spec to https://www.pypa.io/en/latest/specifications/ ?
The PEP should keep motivation and design decisions, but keeping the current version of a specification in an immutable document is debt.

@woodruffw
Copy link
Contributor Author

Would it be possible to add the spec to pypa.io/en/latest/specifications ?

Opened a PR for this: pypa/packaging.python.org#1646

(This is a funky spec addition, since it spans both PyPA and non-PyPA standardized aspects of packaging. But I've made an effort to carve those joints accurately 🙂)

Signed-off-by: William Woodruff <[email protected]>
Comment on lines +17 to +19
.. canonical-pypa-spec:: :ref:`packaging:index-hosted-attestations`

.. canonical-doc:: `PyPI - Digital Attestations <https://docs.pypi.org/attestations/>`__
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: I've left both the spec and doc links in, since the spec is useful to implementors and the doc is useful to consumers. But I'm happy to remove the doc link if convention is to only link the PyPA spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants