Typeshed maintainers: do you want to opt in to HacktoberFest?

[gvanrossum]

HacktoberFest changed to opt-in: https://hacktoberfest.digitalocean.com/hacktoberfest-update

Since contributing to typeshed is pretty simple, I expect the typical HF contributor to be more successful trying to contribute to typeshed than to e.g. mypy or cpython.

[JelleZijlstra]

Sounds worth it to opt in, yes!

Though reading those blog posts, I remember seeing an uptick in PRs on various repos that didn't seem like they'd fix anything useful. I wonder whether those were from Hacktoberfest participants. Anyway, we can deal with those PRs pretty easily.

[gvanrossum]

Digital Ocean's HacktoberFest is infamous for encouraging kids to spam projects, but this year it seems they are (finally!) listening to maintainers, and the rules to prevent spam have been tightened (I think if maintainers mark a PR as spam that counts doubly against the contributor's reputation or something). For typeshed I think the reward will be higher than the risk.

[srittau]

While a bit cautious, I think we could give it a try.

[gvanrossum]

Okay, let’s do it. Can one of you do the honors?

[srittau]

Done. I also added more topics (we had none yet). Let's leave this issue open until October is over, so we remember to remove the topic again.

[hauntsaninja]

I pinned #4641 so that potential contributors can be a little bit more self sufficient when it comes to finding easy improvements to make. (As I mentioned in that issue, feel free to edit the text!)

I think it's pretty savvy of us to make this change two weeks into October :-)

[gvanrossum]

I think it's pretty savvy of us to make this change two weeks into October :-)

Well, I had been watching the drama via a GitHub focus group for high-profile open source maintainers, and opened this issue once DigitalOcean announced they would make it opt-in and changed other rules to discourage spam.

Thanks for the pinned issue!

[srittau]

October is over and I have removed the label. Thanks for the suggestion!

[gvanrossum]

Did we get any good PRs?

[JelleZijlstra]

I don't recall any PRs that were labeled as being from hacktoberfest.

[srittau]

Me neither, unfortunately.

[vbarbaresi]

I opened a few PRs that were incentivized by Hacktoberfest, I have to say (also opened some on mypy even if it wasn't counting)
Thanks hauntsaninja for the pinned issue about Good ways to contribute, that was really helpful.

So I'm encouraging you to keep doing this next year!

[vbarbaresi]

I just discovered that removing the hacktoberfest topic makes digitalocean consider you opted out, so PRs don't count anymore.
Would it be too much to ask that you keep the topic for ~2 weeks? There's a review period that lasts 14 days (even if the PR are already merged)

[srittau]

Sure, I re-added it for now.

[cy]

Yes, I submitted two redis-py stub PRs here incentivized by Hacktoberfest although I've submitted before :) Unfortunately, because the tag was removed the PRs were invalidated and didn't become valid again after it was re-added.

At least my PRs were merged and I contributed to open source even if they didn't count for Hacktoberfest, thanks @srittau for reviewing me, I learned a few things ✨

[srittau]

It's unfortunate the PRs were invalidated. If I can do anything to help make them valid again, please let me know.

[srittau]

For the record, I removed the hacktoberfest for good now.