Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubs for unidiff #11860

Merged
merged 7 commits into from
May 4, 2024
Merged

Add stubs for unidiff #11860

merged 7 commits into from
May 4, 2024

Conversation

JelleZijlstra
Copy link
Member

A pretty simple library. It has inline type comments, so stubgen was able to
write most of the stubs for me.

There is an open issue about switching to inline types (matiasb/python-unidiff#117).

A pretty simple library. It has inline type comments, so stubgen was able to
write most of the stubs for me.

There is an open issue about switching to inline types (matiasb/python-unidiff#117).

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@hamdanal hamdanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I left you some inline comments based on my reading of the source code.

stubs/unidiff/unidiff/__init__.pyi Outdated Show resolved Hide resolved
stubs/unidiff/unidiff/__init__.pyi Outdated Show resolved Hide resolved
stubs/unidiff/unidiff/constants.pyi Outdated Show resolved Hide resolved
stubs/unidiff/unidiff/patch.pyi Outdated Show resolved Hide resolved
stubs/unidiff/unidiff/patch.pyi Outdated Show resolved Hide resolved
stubs/unidiff/unidiff/patch.pyi Outdated Show resolved Hide resolved
stubs/unidiff/unidiff/patch.pyi Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented May 4, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Contributor

@hamdanal hamdanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srittau srittau merged commit 9c8c9c7 into python:main May 4, 2024
42 checks passed
@JelleZijlstra JelleZijlstra deleted the unidiff branch May 4, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants