-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stubs for unidiff #11860
Add stubs for unidiff #11860
Conversation
A pretty simple library. It has inline type comments, so stubgen was able to write most of the stubs for me. There is an open issue about switching to inline types (matiasb/python-unidiff#117).
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I left you some inline comments based on my reading of the source code.
Co-authored-by: Ali Hamdan <[email protected]>
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A pretty simple library. It has inline type comments, so stubgen was able to
write most of the stubs for me.
There is an open issue about switching to inline types (matiasb/python-unidiff#117).