Improve jwcrypto

[donBarbos]

No description provided.

[srittau]

Thanks, one note about overloads below.

[srittau]

Considering that the default is False, the first overload should just use that as default.

The second overload currently technically matches if someone doesn't provide the as_dict argument. We should skip the default. Unfortunately, just skipping it leads to a Python syntax error, which is why we need two overloads instead. (See overloads 2 and 3 in the suggestion below.)

I'd skip the third "fallback" overload, as the other overloads theoretically cover all cases. It's unlikely (though possible) that someone passes a bool variable or argument to this.

Suggested change

	@overload
	def export(self, private_key: bool = True, as_dict: Literal[False] = ...) -> str: ...
	@overload
	def export(self, private_key: bool = True, as_dict: Literal[True] = ...) -> dict[str, Any]: ...
	@overload
	def export(self, private_key: bool = True, as_dict: bool = False) -> str | dict[str, Any]: ...
	@overload
	def export(self, private_key: bool = True, as_dict: Literal[False] = False) -> str: ...
	@overload
	def export(self, private_key: bool, as_dict: Literal[True]) -> dict[str, Any]: ...
	@overload
	def export(self, *, as_dict: Literal[True]) -> dict[str, Any]: ...

The same for the other "export" methods below.

[donBarbos]

I updated overload but left type hints : bool for other export_* functions that don't have other arguments

I think it won't hurt

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉