Skip to content

Regex Match.group returns None #3914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Regex Match.group returns None #3914

wants to merge 2 commits into from

Conversation

djb4ai
Copy link
Contributor

@djb4ai djb4ai commented Apr 7, 2020

closes #3902

@djb4ai
Copy link
Contributor Author

djb4ai commented Apr 7, 2020

@srittau Can't figure out what is the default value of __group.

@JelleZijlstra
Copy link
Member

I feel like we should try this on a large codebase first; I'm worried that it will cause lots of false positives.

Also, your first two overloads can be combined and the last shouldn't have = ....

@hauntsaninja
Copy link
Collaborator

I posted some stuff on the corresponding issue (#3902), in particular, it looks like this change was attempted and then reverted.

@djb4ai djb4ai closed this Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Match.group can return None
3 participants
@djb4ai @JelleZijlstra @hauntsaninja