Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial sphinx docs setup #814

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Initial sphinx docs setup #814

merged 2 commits into from
Jun 4, 2021

Conversation

shannonzhu
Copy link
Contributor

Run Sphinx initialize to set up structure for Python typing documentation.

See typing-sig discussion: https://mail.python.org/archives/list/[email protected]/thread/4E7V7MVO4FQVYPVELMCAYFEIYJRXDSY2/
Python docs community issue: python/docs-community#8

docs/conf.py Outdated
Comment on lines 21 to 22
copyright = '2021, shannonzhu'
author = 'shannonzhu'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the correct copyright and author is. Filled in placeholders but will fix based on suggestions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest saying something like "The typing team"

.. toctree::
:maxdepth: 2
:caption: Contents:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open to thoughts / follow-up PRs for a good initial skeleton TOC to shape the first iteration of docs!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much do we want to steal from mypy docs? https://mypy.readthedocs.io/en/latest/#overview-type-system-reference

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Thanks so much for championing this change. I just have one minor point for discussion below :).

# The theme to use for HTML and HTML Help pages. See the documentation for
# a list of builtin themes.
#
html_theme = 'alabaster'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should consider using the python docs theme https://github.com/python/python-docs-theme to convey that this is the official docs for typing and friends.

Another one to consider: recently I've seen some people in the docs WG using the furo theme https://github.com/pradyunsg/furo for new docs too since its more responsive on mobile browsers. Maybe we can get some input from them later on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea - following up (a bit late) with #818 to set up python docs theming and hopefully an easier build for this. Also open to using the furo theme instead, if you'd be willing to help investigate and change it!

@stefanv
Copy link

stefanv commented Jun 4, 2021

How about merging this with suggested changes and then iterating as necessary? I think this is a fine start.

@JelleZijlstra
Copy link
Member

Good point, I'll merge this PR now and we can write more docs in new PRs.

@JelleZijlstra JelleZijlstra merged commit 2de0a93 into python:master Jun 4, 2021
@shannonzhu shannonzhu deleted the docs branch June 9, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants