Parse XLSX files with unusual structure #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has conflicts with master because I based it on 2.5.3 which doesn't have the performance regressions described in #122. |
Normally you will find `workbook.xml` in the `xl` directory, but recently we got a file where it was located in the root. To find the actual location of workbook, we must parse the file `_rels/.rels`. A separate rels file located relative to the workbook then points out the locations of the sheets, styles and shared strings.
stenlarsson
force-pushed
the
parse-unusual-structure
branch
from
661a6c6 to
e46a9d8
Compare
We found an XLSX missing the `_rels/.rels` file, and in this case falling back to the default path worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally you will find
workbook.xmlin thexldirectory, but recently we got a file where it was located in the root.To find the actual location of workbook, we must parse the file
_rels/.rels. A separate rels file located relative to the workbook then points out the locations of the sheets, styles and shared strings.