update loss utilities to take stage #1077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H-Huang
added a commit
that referenced
this pull request
Apr 22, 2024
ghstack-source-id: 3b39366678901416cd57e2d82c21f91c41a640c0 Pull Request resolved: #1077
kwen2501
approved these changes
Apr 22, 2024
Comment on lines
+63
to
+67
| # if stages not a list turn into a list | ||
| if not isinstance(stages, list): | ||
| stages = [stages] | ||
| contains_last_stage = any([stage.is_last for stage in stages]) | ||
|
|
There was a problem hiding this comment.
Because of this, maybe consider having two versions of this utility? One for single-stage schedules, the other for multi.
H-Huang
added a commit
that referenced
this pull request
Apr 22, 2024
ghstack-source-id: 3b39366678901416cd57e2d82c21f91c41a640c0 Pull Request resolved: #1077
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit some errors where the non-last stage is trying to get the loss or updating internal losses, so these changes fix that.
Stack from ghstack (oldest at bottom):