Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate the release artifacts build: from release/2.4 branch #2987

Closed
wants to merge 32 commits into from

Conversation

lanluo-nvidia
Copy link
Collaborator

@lanluo-nvidia lanluo-nvidia commented Jul 4, 2024

Description

Added two github workflows for the automate release artifacts:

  • release-linux:
    4 auditwheel repaired wheel (python version: 3.8/3.9/3.10/3.11, cuda version: cu124)
    1 pre-cxx11-abi tarball (python version: 3.10, cuda version: cu124)
    1 cxx11-abi tarball (python version: 3.10, cuda version: cu124)
    Here is the 2.4.0 linux release artifacts: https://github.com/pytorch/TensorRT/actions/runs/9816517467#artifacts
note: 
cxx11-abi tarball build requires glibc to be 2.35, base image pytorch/manylinux-builder:cuda12.4 which has gcc 9.3.1, glibc 2.17, I cannot use this base image to build cxx11-abi tarball
so I used our docker image which has base image: nvidia/cuda:12.4.1-devel-ubuntu22.04
which has gcc 11.4.0, glibc 2.35 to build cxx11-tarball
  • release-windows:
    4 wheel file(python version: 3.8/3.9/3.10/3.11, cuda version: cu124)

Here is the 2.4.0 windows release artifacts:
https://github.com/pytorch/TensorRT/actions/runs/9816933636#artifacts

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia added the WIP Work is in progress, pull request should not be merged yet label Jul 4, 2024
@lanluo-nvidia lanluo-nvidia self-assigned this Jul 4, 2024
@lanluo-nvidia lanluo-nvidia added the build-release-artifacts Build the release artifacts label Jul 5, 2024
@lanluo-nvidia lanluo-nvidia added the ciflow/binaries/all Build for all Python Versions label Jul 5, 2024
Copy link

pytorch-bot bot commented Jul 5, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@github-actions github-actions bot added the component: build system Issues re: Build system label Jul 5, 2024
@lanluo-nvidia lanluo-nvidia removed the WIP Work is in progress, pull request should not be merged yet label Jul 6, 2024
@github-actions github-actions bot removed the component: build system Issues re: Build system label Jul 6, 2024
@lanluo-nvidia lanluo-nvidia changed the title Test only: from release/2.4 branch Automate the release artifacts build: from release/2.4 branch Jul 8, 2024
@lanluo-nvidia
Copy link
Collaborator Author

new PR: #2988
is replacing this, closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-release-artifacts Build the release artifacts ciflow/binaries/all Build for all Python Versions cla signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants